search

systopia / de.systopia.xcm

CiviCRM Extended Contact Matcher
Other
5 stars 10 forks source link

Add fill options for Phone and E-mail details #83

Open jaapjansma opened 3 years ago

jaapjansma commented 3 years ago

With the fill details options I would expect that a phone number is added when no phone number with the location type and phone type exists.

When a phone number with that location type and phone type already exists I would expect that nothing changes. However the new phone number gets added and I end up with two phones of the same location type and phone type.

This PR enhances the settings for fill details for phone numbers. The same issue also exists with e-mail addresses and this PR also fixes it for the e-mail addresses.

Before

Below a screenshot of the settings screen:

Screenshot_20210716_111251

After

Below a screenshot with the changes applied to the settings screen:

Screenshot_20210716_111917

And for e-mail

Screenshot_20210726_154510

The changes are backwards compatible. Meaning that if someone had selected phone at the Fill details, the Fill Phone is set to If contact has not this phone number.

Comment

This PR also removes the phone_numeric field from the diff activity.

jaapjansma commented 3 years ago

I have also added a fix for #85 which deals with the same issue but then for email. It was not really possible to create two PRs because the code would interfere with this PR.

bjendres commented 2 months ago

Hi @jaapjansma and @artfulrobot, we're currently compiling a 1.14-alpha what's the status of this PR? Does it need further work/clarification or would you both give a thumbs-up for the current state?

jaapjansma commented 1 month ago

@bjendres it has been a while ago since I wrote this PR. So I don't know exactly what the status is.

jaapjansma commented 3 weeks ago

@bjendres I did an upgrade for a client which is using this functionality. So I checked this PR. And a rebase. Resolved merge conflicts. And also had a look at the feedback from @artfulrobot which was helpful and followed up his advice.

Can you have another look and possible merge this?