syt0r / Kanji-Dojo

A multi-platform application for memorizing Japanese language
GNU General Public License v3.0
211 stars 4 forks source link

[Bug] Decks are sorted by the last letter review time and not the deck review time #189

Open ThomasLeigh opened 1 week ago

ThomasLeigh commented 1 week ago

Earlier on it was independent from any characters scheduled for repetition. If, for example, I've drawn the whole grade 5 Kanji 5 days ago, but today Kanji Dojo gave me - among others - some grade 5 characters to exercise - once I've done the exercise, the grade 5 as a whole set stays still with "5 days ago" last review time. This allows to nicely sort whole sets, day by day, with fixed order - which is especially important is you draw whole sets routinely.

Now it seems it is no longer possible, because it seems that if you draw some characters scheduled for today practice, their whole mother sets' last review time is affected.

Could You please restore character sets last review time to independent from charters appointed repetitions?

syt0r commented 1 week ago

Yes, seems like there's a bug there, I'm redoing that part for the next update so it will be fixed. But note that the last deck review time will be updated when starting reviews from the home screen, time will be updated for the top most deck that contains the reviewed letter

ThomasLeigh commented 1 week ago

Yes, seems like there's a bug there, I'm redoing that part for the next update so it will be fixed. But note that the last deck review time will be updated when starting reviews from the home screen, time will be updated for the top most deck that contains the reviewed letter

Could you do deck last review time dependent only from practicing it fully? In other words. deck last review time is about the deck as a whole - it should be updated only when the deck has been fully practiced.

syt0r commented 1 week ago

It could be done, but decks aren't fully reviewed very often, so I think sorting the decks manually shouldn't be too much of a problem

ThomasLeigh commented 1 week ago

It could be done, but decks aren't fully reviewed very often, so I think sorting the decks manually shouldn't be too much of a problem

The thing is I draw one full grade each day (grade 1, 2, 3.... and back again) and thanks to previous sort logic I hadn't need to look for the proper deck to practice for today because it had always been placed on the very bottom.

Lack of that undisturbed sort logic eliminates the everyday convenience and sense of sorting whole decks by last review time, especially for students who practice whole decks. As a result, now I often need to check in the other app which full deck I practiced yesterday.

ThomasLeigh commented 6 days ago

@syt0r Could you please restore decks last review time as dependent only from their full practice?

syt0r commented 5 days ago

It can be made as an extra sorting option in future, but I can't make it as a default behavior, otherwise regular users might have decks sitting for months in the list marked as not reviewed at all

ThomasLeigh commented 5 days ago

It can be made as an extra sorting option in future

Would You please add such a sorting? It makes a big difference for me, it was a great improvement when long time ago You've introduced sorting sets by last review time, it made a big big difference, the everyday practice had been much more seamless thanks to this very thing, because I didn't need to wonder or remind myself each and every time what set I've done last time. The proper set to practice had been always on the very bottom.