[Front End] - Refactoring Existed Demos

syt123450 / Three.js-Solar-Exploration

:rocket: Exploration the solar system created by Three.js

http://solar-exploration.com/

MIT License

26 stars 6 forks source link

[Front End] - Refactoring Existed Demos #33

Closed syt123450 closed 7 years ago

syt123450 commented 7 years ago

As developers, we want to use the code in our project and make our code more readable , so that I want to refactoring our code.

Define done:

Refactoring and push code to master branch, everyone comments in this issue that the refactoring work is finished.

syt123450 commented 7 years ago

I have refactored all my demos.

zchholmes commented 7 years ago

I have refactored all my demos (earthPrototype and orbitPrototype).

For @BoTime:

It seems like you've added some codes in my orbitPrototype for camera tracing. Can you have a look and coordinate the "orbitPrototype.js"? It doesn't work properly after I move all camera settings into the "updateCamera" function. I have no idea why.
You can test by uncomment the "updateCamera()" in the "orbitAnimate()" method. Let me know if you have any doubts.

bouyuc commented 7 years ago

Done

BoTime commented 7 years ago

@zchholmes Instead of debugging "orbitPrototype.js", I refactored my "camZoomInAndZoomOutPrototype.js" based on your latest demo "solarSystemScene.js". Right now the camera function would not interfere with your original code.

It's safe to delete updateCamera() from your code now. Also I rename the function to zoomInCamera() in the refactored demo.

BoTime commented 7 years ago

refactored (raycasterPrototype.js, camZoomInAndZoomOutPrototype.js, lightingPrototype.js). Done.