sytsereitsma / mdbook-plantuml

mdBook preprocessor to render PlantUML diagrams to png images in the book output directory
MIT License
78 stars 15 forks source link

FIX: url concatenation leads to double slashes #19

Closed plaflamme closed 4 years ago

plaflamme commented 4 years ago

If server_url is something like http://some-server.com, the current string concatenation strategy will lead to a // in the url, e.g.: http://some-server.com//svg/AbcD which can result in a 404 from the plantuml server (at least that's what the Docker image returns).

The fix is to ensure that the provided path always ends with a / and then use Url::join to build the resulting path.

sytsereitsma commented 4 years ago

Thanks