search

sytsereitsma / mdbook-plantuml

mdBook preprocessor to render PlantUML diagrams to png images in the book output directory
MIT License
76 stars 14 forks source link

Add option to make PlantUML images clickable #23

Closed YushiOMOTE closed 2 years ago

YushiOMOTE commented 2 years ago

PlantUML images become clickable for zoom by setting the new option in the config. This is convenient for large diagrams which are hard to see in the book.

sytsereitsma commented 2 years ago

Thanks Yushi. Not sure when I'll get to a new release, so bear with me a little bit

sytsereitsma commented 2 years ago

@YushiOMOTE I'd like to merge this one too, unless you have more to add.

One question. My next change will add support for data URIs, do you have any idea how we could make these clickable without the need for duplicating the URI?

Reason for data URIs is that I now have to place the generated files inside the src/chapter dir of mdBook, causing an additional regeneration when running mdbook serve. I dropped a PR in mdBook to properly handle this, but so far this has not been merged. So I decided to work around it.

sytsereitsma commented 2 years ago

Closed. Merged with https://github.com/sytsereitsma/mdbook-plantuml/pull/37