search

sytsereitsma / mdbook-plantuml

mdBook preprocessor to render PlantUML diagrams to png images in the book output directory
MIT License
76 stars 14 forks source link

use base64 crate for encoding #29

Closed danieleades closed 2 years ago

danieleades commented 2 years ago

use the base64 crate, rather than hand-rolling this

sytsereitsma commented 2 years ago

Unit test is failing. The padding characters have changed from 00 to ==. Still seems to work, so please fix the unit test to use the new padding characters.

danieleades commented 2 years ago

Unit test is failing. The padding characters have changed from 00 to ==. Still seems to work, so please fix the unit test to use the new padding characters.

ah rats. I think I only ran the unit tests in the base64_plantuml module....

should be working now

sytsereitsma commented 2 years ago

Hi Daniel. Can you resolve the conflicts after my merge of your other PR?

danieleades commented 2 years ago

rebased. this is ready for review

sytsereitsma commented 2 years ago

Working down the line... You'll have to do some more rebasing I'm afraid.