search

sytsereitsma / mdbook-plantuml

mdBook preprocessor to render PlantUML diagrams to png images in the book output directory
MIT License
76 stars 14 forks source link

add coverage workflow #47

Closed danieleades closed 1 year ago

danieleades commented 2 years ago

adds a code coverage worflow.

requires a codecov.io account to work (you can use github credentials)

you can a sample of the report in my fork - https://github.com/danieleades/mdbook-plantuml/pull/2

sytsereitsma commented 2 years ago

Not really comfortable with allowing codecov access to my private repos. How do you handle that?

danieleades commented 2 years ago

Not really comfortable with allowing codecov access to my private repos. How do you handle that?

unsure. I've only linked it to my public repos (which it effectively already has access to)

danieleades commented 2 years ago

looks like there's a separate access scope for private repos on github that must be authorised separately - https://docs.codecov.com/docs/video-guide-connecting-codecov-to-github#step-3-granting-private-scope

danieleades commented 1 year ago

any remaining issues here?

sytsereitsma commented 1 year ago

My reservations have not changed. Codecov.io needs/has access to the private repos. I'll close the PR.

danieleades commented 1 year ago

My reservations have not changed. Codecov.io needs/has access to the private repos. I'll close the PR.

that's not strictly true. Private repos have a separate access scope, which must be explicitly enabled. Without enabling that access, Codecov.io only has access to your public repos.