search

syuilo / summaly

🔍 Get a summary of any web page
MIT License
51 stars 25 forks source link

Some requests use the default "got" user-agent string instead of Summaly #153

Open jprjr opened 2 months ago

jprjr commented 2 months ago

Hi there - it looks like Summaly only sets the bot user-agent in one place in the code -https://github.com/syuilo/summaly/blob/b994e67281abc3faae53c888a232c84a4ea1a01d/src/utils/got.ts#L13C23-L13C31

This causes other requests to go out with the Got user-agent string and leads to confusion. For example, this one person believes the author of Got is the author of Summaly - https://www.hacker-idioten.com/login-idioten/willkommen-ihr-login-idioten

I would suggest adding the BOT_UA header here and here so that they all show as Summaly in web logs.

AmaseCocoa commented 2 months ago

It seems syuilo/summaly has not been updated for a long time. Perhaps it would be better to submit an issue to misskey-dev/summaly, etc.

See also: https://github.com/syuilo/summaly/issues/152