syusui-s / rabbit

🐰 A nostr client like TweetDeck
https://rabbit.syusui.net
GNU Affero General Public License v3.0
66 stars 13 forks source link

fix: add horizontal space #101

Closed fernandolguevara closed 2 weeks ago

fernandolguevara commented 4 weeks ago

Added space between user display name & action

before:

image

after:

image
syusui-s commented 3 weeks ago

Please use whitespace-pre instead of space-x-1. Space is needed between words in English. However, space is not needed in Japanese.

https://github.com/syusui-s/rabbit/pull/101/files#diff-023a037313ed9c7607e97a35218f60fa3b2b8f558a0a555ec57e59ae752b2d67R69

-            <span class="shrink-0">{i18n.t('notification.reacted')}</span>
+            <span class="shrink-0 whitespace-pre">{i18n.t('notification.reacted')}</span>

https://github.com/syusui-s/rabbit/blob/main/src/locales/en.ts#L136 https://github.com/syusui-s/rabbit/blob/main/src/locales/ja.ts#L132

syusui-s commented 2 weeks ago

Thank you for your suggestion but I fixed the issue in this commit: e0724f8fc95ed542f58a1c64cae96e146292388f

If this solves the issue, could you close this PR?