syxolk / euro2024

Euro 2024: Betting with your friends
https://www.wetten2024.de
52 stars 22 forks source link

Saving bets #17

Closed gunnartorfis closed 6 years ago

gunnartorfis commented 8 years ago

Some of my users are having issues with saving their bets, they don't get saved (when they refresh again, the bets are gone). I didn't have any issues myself though.

They do have Javascript endabled in their browser, so that's not the case. Any ideas?

syxolk commented 8 years ago

Nope, I've never experienced this either.

There is a color animation in the text input indicating if saving was successful. It should be red whenever it fails to save.

gunnartorfis commented 8 years ago

Hmmm. The only reason I see why this could go wrong, is when one has Javascript disabled in his browser.

This doesn't make sense for me. They all have JS enabled and no network issues.

syxolk commented 8 years ago

There are at least 5 reasons the request can fail:

For the Javascript problem: Can you ask them about their Browser and Browser version? Really old internet explorers may not be supported. Internet Explorer 11 should work, I just checked it.

gunnartorfis commented 8 years ago

Thanks for the super fast reply mate, really appreciate it. Hope this information helps:

They both tried Chrome and Safari, not sure about versioning. They also tried on their mobile. I'll let you know when I know about their browsers' versions.

gunnartorfis commented 8 years ago

Browser version: Version 50.0.2661.102 (64-bit), running on El Capitan 10.11.4 Javascript is enabled

gunnartorfis commented 8 years ago

Another one.

Safari version 9.0.3 OS X Maverics 10.9.5 Javascript is enabled

syxolk commented 8 years ago

It would be really helpful to see the Network tab in the browser's developer tools (usually opened with F12) while making a bet.

gunnartorfis commented 8 years ago

Sorry for how long it took, just got a hold of the user.

13396769_10154992595239358_89802381_o

syxolk commented 8 years ago

There should be a save_bet request after inserting something in both text fields of one match.

gunnartorfis commented 8 years ago

Well, it's not being issued. Maybe a button that'd issue a regular http request (without JS), would do the trick?

gunnartorfis commented 8 years ago

After I pulled 29c027b99ead409b7959ae120e238e7096a679c5, this is no longer an issue. That commit is not what fixed it though, but I had an old commit.

I'm trying to update to the newest commit, but I'm just afraid about the database. How do I add the new columns without losing any data?

gunnartorfis commented 8 years ago

Any help you could provide me mate? I need to add the Match TV column.

syxolk commented 8 years ago

Execute this SQL: alter table "Match" add column tv character varying(255)