syyePhenomenol / HollowKnight.VanillaMapMod

A mod for Hollow Knight v1.5 that adds all items/locations to the existing map. Similar to RandoMapMod but for non-rando playthroughs.
GNU General Public License v3.0
7 stars 2 forks source link

Some really upsetting stuff #3

Closed Shamshu1 closed 1 year ago

Shamshu1 commented 1 year ago

Hey, I dont think it should works like that Снимок экрана от 2022-11-12 19-56-05 it happens when I open full map and bench after that (disappears only after next map openning) Also I have a problem with some pins dont disappear (eg this charm) Снимок экрана от 2022-11-12 20-01-13 Снимок экрана от 2022-11-12 20-01-33 ModLog.txt Thanks in advance <3

syyePhenomenol commented 1 year ago

Does the problem still remain if you uninstall LoreMaster?

Shamshu1 commented 1 year ago

Yeap

syyePhenomenol commented 1 year ago

Does the button menu on the pause screen still show up? Can you interact with it?

Could you try setting the log level in ModdingApi.GlobalSettings.json to 1, open the game, get back to the same issue, and send the ModLog again? Thanks

Shamshu1 commented 1 year ago

Yeap

on the same file, with fresh one it doesnt appear but problem with some objects (charm, mimic etc) is still there ̶h̶o̶w̶e̶v̶e̶r̶ ̶t̶h̶a̶t̶ ̶h̶a̶p̶p̶e̶n̶e̶d̶ ̶a̶f̶t̶e̶r̶ ̶2̶+̶h̶ ̶i̶n̶ ̶g̶a̶m̶e̶,̶ ̶a̶f̶t̶e̶r̶ ̶b̶e̶n̶c̶h̶ ̶i̶n̶ ̶w̶a̶t̶e̶r̶w̶a̶y̶s̶,̶ ̶s̶o̶.. || a̶f̶t̶e̶r̶ ̶"̶s̶e̶t̶t̶i̶n̶g̶ ̶t̶h̶e̶ ̶l̶o̶g̶ ̶l̶e̶v̶e̶l̶ ̶i̶n̶ ̶M̶o̶d̶d̶i̶n̶g̶A̶p̶i̶.̶G̶l̶o̶b̶a̶l̶S̶e̶t̶t̶i̶n̶g̶s̶.̶j̶s̶o̶n̶ ̶t̶o̶ ̶1̶"̶ ̶i̶t̶ ̶d̶i̶s̶a̶p̶p̶e̶a̶r̶s̶ || :/ sorry, but with reopening files and game it changes, now like that: Снимок экрана от 2022-11-13 02-48-54 ModLog.txt button menu works totally fine

syyePhenomenol commented 1 year ago

To test if this is a problem specific to your current save, could you start a new game, unlock the full map, open it, then rest at a bench? Thanks

Shamshu1 commented 1 year ago

*on the same file, with fresh one it doesnt appear but problem with some objects (charm, mimic etc) is still there

nothing weird happens

syyePhenomenol commented 1 year ago

Oh I see.

I'm still not sure what is causing this. Next would you be able to send your save files? userX.json and userX.modded.json

Shamshu1 commented 1 year ago

user.zip

syyePhenomenol commented 1 year ago

I have found and fixed the problems associated with these pins not disappearing:

Did you encounter any other pins that didn't go away?

I still don't know why the original problem occurs, but at least it seems only limited to that one save.

Shamshu1 commented 1 year ago

Did you encounter any other pins that didn't go away?

No

Shamshu1 commented 1 year ago

I got this in a new file started after mod update о_О (w/o loremaster) Снимок экрана от 2022-11-13 22-21-14 ModLog.txt and I got the trigger - it happens after collecting all maps & quill (Im not sure if its matter doing it by debug mod or in default way) *btw mimics and charms now work fine, thanks)

syyePhenomenol commented 1 year ago

Some things to try: In the DebugModData folder, delete the save states corresponding to the file you are currently on

Delete all mods (including global settings) and reinstall them

The problem is most likely not because of VanillaMapMod.

syyePhenomenol commented 1 year ago

One last thing to try is to delete all userX files corresponding to the current save

Shamshu1 commented 1 year ago

I deleted everything corresponding to hollow knight, reinstalled just the game itself and VanillaMapMod, load into the game, quit out, edited the save (.bak) to have maps & quill and thats it image

syyePhenomenol commented 1 year ago

Thanks for your patience so far. I finally seem to have reproduced the issue and found what is causing it.

syyePhenomenol commented 1 year ago

Please avoid setting "mapAllRooms" to true in the player data. In fact you might not need to edit anything at all.

If you want to see the full map while using VanillaMapMod, all you need to do is to click on the "Mode" button in the pause menu to switch to "Full Map".

Shamshu1 commented 1 year ago

Oh, the very first time I couldn't get all maps (to get rid of their pins) in default way because of other mod, so I did it by debug and all the times after, I was doing it, cause its obviously faster to test. So in normal playthrough it can't happen?

syyePhenomenol commented 1 year ago

Yep, it won't be set to true unless you edit the save yourself.

Shamshu1 commented 1 year ago

Hello once again <3. Shopkeeper's key pin doesnt go away and it seems that it is happening because this pin has a check like 'true if it is in inventory' = pin came back after Sly dialogue

syyePhenomenol commented 1 year ago

Hi, thanks for pointing this out. This should be fixed in the next update of MapChanger