search

syzygy1 / Cfish

C port of Stockfish
GNU General Public License v3.0
137 stars 58 forks source link

To Author of Cfish: Why error in shift_bb(Left... modification #110

Closed abdulbadii closed 4 years ago

abdulbadii commented 4 years ago

Why error in shift_bb(Left.. modification in movegen.c as shift_bb(Right... of such works perfectly here the working modded Cfish: Cfishsrc+Release.zip

If just changing few letters from shift_bb(Left.. to shiftLeft(Us, and the function INLINE Bitboard shift_bb(int Direction, Bitboard b) is completely removed it'll generate error:

... Step 2/4. Running benchmark for pgo-build ... ./cfish bench 16 1 15 > /dev/null /bin/sh: line 1: 592 Segmentation fault ./cfish bench 16 1 15 > /dev/null make: *** [Makefile:423: profile-build] Error 139

How do we figure out this way of failure? ...thanks before

syzygy1 commented 4 years ago

I don't know why you would want to change shift_bb(Left, ...) into shiftLeft(...). The current approach is closest to SF's shift_bb(...). There is certainly no efficiency to gain here, since the compiler can easily optimise shift_bb(Left, ....).

abdulbadii commented 4 years ago

Fine, thanks informing me that.. Sorry bother