search

syzygy1 / Cfish

C port of Stockfish
GNU General Public License v3.0
137 stars 58 forks source link

Fix type errors in nnue.c #167

Closed gsobala closed 3 years ago

gsobala commented 3 years ago

According to the ARM User Guide , the args for vcgtq_s8 should be int8x16_t . The original code throws type errors with gcc 10.2 on armv8 / raspberry pi 4. This PR compiles without warnings or errors, is slightly faster than the non-TRANSPOSE version, and passes sanity checks on benchmarks.

syzygy1 commented 3 years ago

Thanks. I'm not sure why I made it uint8x16_t. For some reason Clang doesn't complain.