search

szabgab / wis-python-course-2024-04

16 stars 9 forks source link

Day6_Roi Siegelman #140

Closed roisiegelman closed 3 months ago

roisiegelman commented 3 months ago

Hi Gabor: The script that I have written takes an excel file that contains results from RNA sequencing (MARS seq) that compares two groups:

  1. WT_PyMT: No.I and WT.sc
  2. NSD1-KO: KO.2 and KO.3

I wanted to create a barplot that shows the top 10 genes with the highest fold-change for each group. the genes were first filtered for significance (P value <0.05)

https://github.com/roisiegelman/assignmets/tree/main/Day6: $ python generate_barplot.py Roi_MARSseq.xlsx

szabgab commented 3 months ago

You've added lot of files in the Project and temp folders. Was that your intention? There are also a couple of files in the root folder. Is that intentional? If not maybe you'd want to remove them.

There are still __pycache__ folders in Day3 and Day5, Please remove them.

There is still no .gitignore file.

Please put the explanation about Day6 in a README.md file in the day6 folder.

Running pytest it now shows an image and I need to click on it in order to continue. The test should not require any user interaction.

roisiegelman commented 3 months ago

Hi Gabor, I've deleted some of the files and addressed all the points you raised

szabgab commented 3 months ago

nice.

The top_genes_barplot.png file should also be listed in the .gitignore file or in a temporary folder. We'll discuss this during the lecture today.