szabgab / wis-python-course-2024-04

16 stars 9 forks source link

day07 - Yael Arieli #162

Closed yaelarieli closed 3 months ago

yaelarieli commented 3 months ago

https://github.com/yaelarieli/wis-python-course-hw/tree/main/day07

szabgab commented 3 months ago

If you put the command line text inside a pair of backticks (the same button as ~) in the README file then they look better: search_ncbi(termx,numberx) vs. search_ncbi(termx,numberx)

$ python hw7.py 
Usage: hw7.py FILENAME
$ python hw7.py cat
Usage: hw7.py FILENAME

The instructions printed by the program are not correct.

This worked, but I think given that the code downloads GeneBank files, the saved files should have an extension .genbank not just the term and the id.

$ python hw7.py cat 3
cat_NZ_CP151555.1
cat_NZ_JAZKJQ010000003.1
cat_NZ_CP084032.1
szabgab commented 3 months ago

Oh and I forgot to say: nice work :)

yaelarieli commented 3 months ago

Thanks!