Closed zbeekman closed 9 years ago
sigh… please don’t merge this yet @szaghi let me rebase my changes onto the issues we fixed. This will make life much easier for you
OK, I rebased my fork onto the latest origin/master, so, if the checks pass and there are no merge conflicts it should be ready to merge. If the checks fail or there are merge conflicts, I’ll try to fix them for you, so hold off on merging if that happens.
IMPORTANT: I have removed the encrypted GH_TOKEN variable from the .travis.yml, so that it can be added directly on Travis-CI through the repository settings web interface. I think that using the web interface does a better job of making sure that variable contents don’t leak into the logs. Generate your new GH token then head over to: https://travis-ci.org/profile/szaghi and then click the gear ‘settings’ icon next to szaghi/FLAP. Then click on the ‘environment variables’ tab and ‘add new variable’. Then enter GH_TOKEN for the name and the corresponding newly generated token as the value. Make sure that the ‘display value in build logs’ setting is set to ‘off’. Please do this before attempting to merge this PR so we can see if the documentation deploys correctly and whether or not the token is exposed.