search

szaghi / FLAP

Fortran command Line Arguments Parser for poor people
151 stars 34 forks source link

Potential BUG in FLAP (varying size parameters) #49

Closed victorsndvg closed 9 years ago

victorsndvg commented 9 years ago

Some minor changes related with the following issue: https://github.com/szaghi/FLAP/issues/48

codecov-io commented 9 years ago

Current coverage is 65.24%

Merging #49 into master will increase coverage by +0.02% as of 6d939a0

@@            master     #49   diff @@
======================================
  Files            5       5       
  Stmts         2171    2172     +1
  Branches         0       0       
  Methods          0       0       
======================================
+ Hit           1416    1417     +1
  Partial          0       0       
  Missed         755     755

Review entire Coverage Diff as of 6d939a0

Powered by Codecov. Updated on successful CI builds.

szaghi commented 9 years ago

Thank you victor!

victorsndvg commented 9 years ago

You'r welcome :)

We are not sure that this is a final fix for this problem...

I have some doubts.

Are you sure that you want to maintain allocated the cla%val if the argument is not passed? Why you have both cla%val and cla%def? is cla%def status re-initialized? Another option to fix this issue is to create a new flow for FLAP when cla%val is not allocated

szaghi commented 9 years ago

Cla%def is the one that must be used when a not required cla is gotten without being passed, thus I do not like to have cla%val allocated in this case, but as I said I am out of office and I cannot check it. Your workaround is nuce as temporary patch until I cannot check it. For this reason I prefer to leave open this issue. In the meanwhile, feel free to suggest other patches :-)