Closed pdebuyl closed 5 years ago
Merging #83 into master will increase coverage by
14.28%
. The diff coverage isn/a
.
@@ Coverage Diff @@
## master #83 +/- ##
===========================================
+ Coverage 60.49% 74.77% +14.28%
===========================================
Files 13 13
Lines 1792 1792
Branches 499 0 -499
===========================================
+ Hits 1084 1340 +256
Misses 452 452
+ Partials 256 0 -256
Impacted Files | Coverage Δ | |
---|---|---|
src/lib/flap_utils_m.f90 | 81.66% <0%> (+8.33%) |
:arrow_up: |
src/lib/flap_command_line_arguments_group_t.f90 | 78.5% <0%> (+9.34%) |
:arrow_up: |
src/tests/flap_test_group.f90 | 100% <0%> (+12.72%) |
:arrow_up: |
src/lib/flap_command_line_argument_t.F90 | 61.59% <0%> (+16.24%) |
:arrow_up: |
src/lib/flap_command_line_interface_t.F90 | 73.32% <0%> (+19.1%) |
:arrow_up: |
src/lib/flap_object_t.f90 | 100% <0%> (+32.07%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 033549b...a23c91f. Read the comment docs.
Hi @szaghi
The license agreement is weird.
I see nowhere the fact that the contributions will remain under the license of FLAP. For a commit updating a submodule reference it is not that important but I would be wary of contributing more code under such a vague agreement.
Hi,
I am going lost, can you explain in more details the license issue?
The message from @CLAassistant redirectes to an agreement in which I waive all rights whatsoever on the code. In general, I contribute code under the license of the repository (here multiple: GPLv3, BSD2-Clause, BSD3-Clause and MIT -- a practice that I find really nice by the way) and expect that the code wil remain open-souce. The agreement presented by @CLAassistant is more general than that however.
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.