search

szaranger / firebase-saga

A library for connecting redux-saga middleware to Firebase.
58 stars 15 forks source link

ReferenceError: firebase is not defined #7

Closed bitIO closed 7 years ago

bitIO commented 7 years ago

I'm getting this error 

ReferenceError: firebase is not defined
   at sync$ (webpack:///./~/firebase-saga/dist/ReactProxy.js?:446:18)
   ...

It is referring to the sync method. I don't see any import of the firebase tool in the code with the functions.

These are my installed versions:

Are there any special requirements to use firebase-saga?

szaranger commented 7 years ago

Hi @bitIO ,

It seems to be some changes they have made in the latest firebase version.

Could you remove firebase from npm_modules and install 3.2.0 like follows:

npm install --save firebase@3.2.0

I will have it fixed at some point, but for now I'm gonna lock the version to `3.2.x' for firebase.

bitIO commented 7 years ago

Ok, the workaround is also to make it available by making it global (if needed). Not clean but also works 🤔

szaranger commented 7 years ago

Locking in the version is better in terms of avoiding different versions in global.

bitIO commented 7 years ago

It can be closed since it's pretty clear the issue is caused by third party lib (although it's a dependency 😝)