search

szarroug3 / X-Ray_Calibre_Plugin

X-Ray Creator plugin for Calibre
http://www.mobileread.com/forums/showthread.php?t=273189
GNU General Public License v3.0
57 stars 12 forks source link

Fix a few issues in the same bit of code #21

Closed stoduk closed 8 years ago

stoduk commented 8 years ago

Fixes #20 - use existing 'device' variable to find the Kindle Fixes #2 - fixed as I needed to modify this code anyway Fixes a potential bug (use of "not is" instead of "!=")

Note: I have tested on OS X, but not Windows. Can you check that still works? Should be fine, we are using 'device' elsewhere, and that is the biggest change.

Also - any reason we needed to be doing the os.walk instead of just directly modifying the file? If there is my fix might not work, but I couldn't see any reason not to explicitly name the file to rename.

stoduk commented 8 years ago

@szarroug3 note there is some mention of conflict merging here, that only you have permissions to do! (you need permissions on the parent repo, which I don't have).

szarroug3 commented 8 years ago

@stoduk I merged it and added you as a collaborator.. Also tested it.. works great! :smile:

stoduk commented 8 years ago

Great, glad it worked :)

On 20 May 2016 at 00:33, szarroug3 notifications@github.com wrote:

@stoduk https://github.com/stoduk I merged it and added you as a collaborator.. Also tested it.. works great! 😄

— You are receiving this because you were mentioned. Reply to this email directly or view it on GitHub https://github.com/szarroug3/X-Ray_Calibre_Plugin/pull/21#issuecomment-220477021