search

szarroug3 / X-Ray_Calibre_Plugin

X-Ray Creator plugin for Calibre
http://www.mobileread.com/forums/showthread.php?t=273189
GNU General Public License v3.0
57 stars 12 forks source link

just some cleanup #61

Closed szarroug3 closed 8 years ago

szarroug3 commented 8 years ago

removed some unnecessary variables; removed query from goodreads url; changed connection to be local variable when it's only needed for one function and global variable when it's needed throughout class -- also removed unnecessary connection passing/returning in functions

stoduk commented 8 years ago

Generally: looks good, I can't see any way this could break things, and it is certainly clearer/cleaner.

Might be a good chance to rename gConnection and aConnection to something clearer - IMO you've abbreviated the wrong bit :) People are pretty clear that conn means connection, but g and a for goodreads.com and amazon.com only makes sense if you know what is what. Not a big problem/doesn't have to have fixed, I may have even mentioned it before!

What triggered this cleanup? This fixes some pylint warnings, so I wondered if that was the trigger. We should probably "fix" everything pylint is warning about (ie. make changes or silence warnings), as it does a good job at finding latent bugs.

szarroug3 commented 8 years ago

Fixed everything you mentioned.. I caught some things while i was doing author profile stuff, figured I'd just do a quick cleanup before creating a new release.. i'm not seeing any warnings.. are you?