szarroug3 / X-Ray_Calibre_Plugin

X-Ray Creator plugin for Calibre
http://www.mobileread.com/forums/showthread.php?t=273189
GNU General Public License v3.0
57 stars 12 forks source link

People have been unable to install/update plugin #89

Closed szarroug3 closed 7 years ago

szarroug3 commented 7 years ago

I was able to recreate the issue by downgrading to 2.2.1 and then trying to update to 3.0.2. Here's the error.

Traceback (most recent call last): File "site-packages\calibre\gui2\preferences\plugins.py", line 317, in add_plugin File "site-packages\calibre\customize\ui.py", line 463, in add_plugin File "site-packages\calibre\customize\ui.py", line 58, in load_plugin File "site-packages\calibre\customize\zipplugin.py", line 199, in load File "site-packages\calibre\customize\zipplugin.py", line 183, in load_module File "calibre_plugins.xraycreator. init ", line 6, in ImportError: cannot import name prefs _

Note: had to change the double to _ so github wouldn't markdown the text to bold instead of the actual filename.

szarroug3 commented 7 years ago

From the investigation I've done so far, it seems like we can't import a global variable in init .py. I've added from calibre_plugins.xray_creator.lib.book_parser import PARAGRAPH_PAT before the problem line and the installer seems to break on that line too but has no problem importing BookParser on the same line.