stoduk
commented
7 years ago I can see the problem - goodreads have changed their DOM so that our matching doesn't work in an annoyingly trivial way :) This might impact us in multiple places, so I'll leave it a while to see if @szarroug3 is around and has a preference on how to fix this.
Full details below, @wevanthomas you may want to ignore this.
Specifically, we've gone from
<div class="mainContent">to
<div class="mainContent ">The test at goodreads.py:525 is currently a bit fragile - as it assumes the entire class will be mainContent, but extra classes could be added legitimately (mainContent somethingElse) , or as we've seen they might just add a trailing whitespace to a single element list.
It would be better to look for elements where one of the class attributes is exactly mainContent but AFAIK there isn't a native xquery way to do this. The best I can find is to change the first part of the test to change from this:
xpath('//div[@class="mainContent"]
to this:
xpath('//div[contains(concat(" ", @class, " "), " mainContent ")]
so the old line 525 now looks like this:
return self._page_source.xpath('//div[contains(concat(" ", @class, " "), " mainContent ")]//div[@id="imagecol"]//img[@id="coverImage"]')[0].get('src')
This (messier but more accurate) test will match a class that looks like any of these:
- 'mainContent'
- 'mainContent '
- 'mainContent somethingElse'
- 'another mainContent' but it won't match these:
- 'mainContentContainer'
szarroug3
Starting job: Creating Files
02-06-2017 00:16:31 Initializing... 02-06-2017 00:16:31 Harry Potter and the Chamber of Secrets - J. K. Rowling 02-06-2017 00:16:31 Parsing Goodreads data... Job: "Creating Files" failed with error: Traceback (most recent call last): File "site-packages\calibre\gui2\threaded_jobs.py", line 84, in start_work File "calibre_plugins.xray_creator.lib.xray_creator", line 284, in create_files_event File "calibre_plugins.xray_creator.lib.book", line 210, in create_files_event File "calibre_plugins.xray_creator.lib.book", line 371, in _parse_goodreads_data File "calibre_plugins.xray_creator.lib.goodreads_parser", line 58, in parse File "calibre_plugins.xray_creator.lib.goodreads_parser", line 93, in _get_non_xray File "calibre_plugins.xray_creator.lib.goodreads_parser", line 525, in _get_book_image_url IndexError: list index out of range
Called with args: (,) {u'notifications': , u'abort': , u'log': }