search

szchenghuang / react-transitions

A collection of animated transitions when React components enter or leave the DOM.
MIT License
35 stars 11 forks source link

[Kind request] Update project #4

Closed MikeDabrowski closed 7 years ago

MikeDabrowski commented 7 years ago

Currently, using this module produces following warnings.

Warning: Accessing PropTypes via the main React package is deprecated. Use the prop-types package from npm instead.  bundle.js:81283:16
Warning: Portal: React.createClass is deprecated and will be removed in version 16. Use plain JavaScript classes instead. If you're not yet ready to migrate, create-react-class is available on npm as a drop-in replacement.

Although they're just a warnings, it might be good to update this project to meet new rules.

szchenghuang commented 7 years ago

It should have been updated to get rid of the warning since the latest release v0.0.3. If you are present the warning against that version, please let me know. Thanks!

MikeDabrowski commented 7 years ago

Yes, I updated to the newest 0.0.3 but still have this problem. I made custom adjustments to your code, but that were mostly css-related changes.

szchenghuang commented 7 years ago

There should be a line designated along with the warning on the console. Did it specify where it complains exactly?

MikeDabrowski commented 7 years ago

Yeah, it shows this image which is not particularly helpful, unless you can tell me how to run react so it would show precise location in your code, not this from bundle ( I don't recognize it to be your code )

MikeDabrowski commented 7 years ago

I combed through my project and removed all remains of previous version - warnings still persist. But I created blank project and no warnings there. So I believe it is my fault then.

Edit: I looked through your dependencies and 

"react-addons-css-transition-group": "^15.3.1",
"react-addons-transition-group": "^15.3.1",

Both are marked as deprecated and will no longer work with React 16+. Simple substitution with react-transition-group produces many errors.

szchenghuang commented 7 years ago

In general tracing the call stack to find out where errors/warnings are resulted from is helpful. Here is one of resources on how to trace it.

Regarding to the dependencies to deprecated xxx-transition-group, it should be improved indeed. Let's trace it in a newly created issue #5 and leave this current one to PropTypes and React.createClass.