szcompressor / SZ

Error-bounded Lossy Data Compressor (for floating-point/integer datasets)
http://szcompressor.org
Other
151 stars 56 forks source link

CMake build under windows using NMake #109

Closed vasole closed 1 year ago

vasole commented 1 year ago

Addresses #91

With these changes, the following instructions build SZ under windows with native MSVC compiler

mkdir build
cd build
cmake .. -G"NMake Makefiles"
nmake
vasole commented 1 year ago

I guess I can make first commit even more conservative (checking for windows without MINGW for instance).

Just let me now if you prefer so.

disheng222 commented 1 year ago

Looks good to me. Thanks a lot for the effort.

vasole commented 1 year ago

Since the check for windows without using MINGW was already used at other places, I have used that approach to resolve the concerns about https://github.com/szcompressor/SZ/pull/109/commits/73065ab1e48bc36e6a407fe3a4cf5c9c1f6b7bd3

robertu94 commented 1 year ago

This looks good to me now @disheng222