szcompressor / SZ

Error-bounded Lossy Data Compressor (for floating-point/integer datasets)
http://szcompressor.org
Other
155 stars 56 forks source link

Port to osx; add support for travis testing. #40

Closed ggorman closed 5 years ago

ggorman commented 5 years ago
ggorman commented 5 years ago

Note that automated testing has already found its first bug (the reason this PR is initially red). If you look at the travis logs you'll see:


  if [ ! -f ../example/testdata/x86/testdouble_8_8_8_128.dat.sz ]; then
     exit 1
  fi
  ./bin/testdouble_decompress ../example/sz.config ../example/testdata/x86/testdouble_8_8_8_128.dat.sz 8 8 8 128
  if [ ! -f ../example/testdata/x86/testdouble_8_8_8_128.dat.sz.out ]; then
     exit 1
  fi

cfgFile=../example/sz.config
timecost=0.040055
done
Wrong version: 
Compressed-data version (35.61.61)
Current sz version: (2.1.6)
Please double-check if the compressed data (or file) is correct.```

So something has gone wrong with sz versioning.
disheng222 commented 5 years ago

Hi, I have merged your pull request to master branch. Thanks.

If you use testdouble_decompress or testfloat_decompress to do the decompression, you should not input the sz.config as parameters. I guess you probably followed the example section in the README, and there was a typo: ./test_decompress sz.config testdouble_8_8_8_128.dat.sz 8 8 8 128 The above command should be : ./test_decompress testdouble_8_8_8_128.dat.sz 8 8 8 128

I have fixed it in README.

Sheng

Best, Sheng

On Sun, Aug 18, 2019 at 7:22 AM Gerard Gorman notifications@github.com wrote:

Note that automated testing has already found its first bug (the reason this PR is initially red). If you look at the travis logs you'll see:

if [ ! -f ../example/testdata/x86/testdouble_8_8_8_128.dat.sz ]; then exit 1 fi ./bin/testdouble_decompress ../example/sz.config ../example/testdata/x86/testdouble_8_8_8_128.dat.sz 8 8 8 128 if [ ! -f ../example/testdata/x86/testdouble_8_8_8_128.dat.sz.out ]; then exit 1 fi

cfgFile=../example/sz.config timecost=0.040055 done Wrong version: Compressed-data version (35.61.61) Current sz version: (2.1.6) Please double-check if the compressed data (or file) is correct.```

So something has gone wrong with sz versioning.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/disheng222/SZ/pull/40?email_source=notifications&email_token=ACK3KSISGVBA7ZHP6UUBYD3QFE5JPA5CNFSM4IMSTHUKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD4Q64GI#issuecomment-522317337, or mute the thread https://github.com/notifications/unsubscribe-auth/ACK3KSNZINPXNHSCAZ7GPL3QFE5JPANCNFSM4IMSTHUA .