search

szcompressor / SZ

Error-bounded Lossy Data Compressor (for floating-point/integer datasets)
http://szcompressor.org
Other
155 stars 56 forks source link

Makefile change to build libhdf5sz.so #57

Closed ajelenak closed 4 years ago

ajelenak commented 4 years ago

Hello!

Building shared libhdf5sz.so library failed for me due to missing symbols from the HDF5 library. Below is the altered build command that worked:

$(CC) -O3 -shared -o $(LIB)/$(SHARED) $(OBJS) $(SZFLAGS) -L$(HDF5PATH)/lib -lc -lSZ -lhdf5 -lzlib -lzstd
disheng222 commented 4 years ago

Thanks for pointing out this possible compilation issue. I guess that's due to different compilers, because the original command also worked on different platforms. I used your recommended one, which also works OK on my testing machines. So, I committed this change.

On Fri, Jul 31, 2020 at 3:32 PM Aleksandar Jelenak notifications@github.com wrote:

Hello!

Building shared libhdf5sz.so library failed for me due to missing symbols from the HDF5 library. Below is the altered build command https://github.com/disheng222/SZ/blob/fbe4d0162c1ffb0dc25c3af164ee83eee41da823/hdf5-filter/H5Z-SZ/Makefile#L56 that worked:

$(CC) -O3 -shared -o $(LIB)/$(SHARED) $(OBJS) $(SZFLAGS) -L$(HDF5PATH)/lib -lc -lSZ -lhdf5 -lzlib -lzstd

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/disheng222/SZ/issues/57, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACK3KSNP4RPZEDZUTZ5CHATR6MS4FANCNFSM4PQ3JFFQ .