A miss-unlocking bug - Githubissues

szcompressor / SZ

Error-bounded Lossy Data Compressor (for floating-point/integer datasets)

http://szcompressor.org

Other

151 stars 56 forks source link

A miss-unlocking bug #89

Open ryancaicse opened 2 years ago

ryancaicse commented 2 years ago

Hi, it seems lock best->mutex is missed to be released before line 815. Should it be a bug? https://github.com/szcompressor/SZ/blob/c30cb7941e1efd4ae9f20ae70879a9a327cce7e9/zstd/dictBuilder/cover.c#L801-L824

robertu94 commented 2 years ago

@ryancaicse this is a bundled version of Zstandard. We don’t really maintain it. Most people who use SZ will install it with a system or spack provided Zstandard rather than this one. If the upstream Zstandard has this same bug fixed, we can look into updating the bundled version

ryancaicse commented 2 years ago

@robertu94 Thank you for your reply. It seems they have fixed it. https://github.com/facebook/zstd/blob/eadb6c874f9d0c9e90c835f8b0181da802361e4c/lib/dictBuilder/cover.c#L920-L950