search

szechyjs / dsd

Digital Speech Decoder
Other
701 stars 271 forks source link

bug in P25 DUID? #52

Closed sbromberger closed 9 years ago

sbromberger commented 9 years ago

Hi all,

I'm looking through dsd_frame.c, and at https://github.com/szechyjs/dsd/blob/master/dsd_frame.c#L270-280 is where the 4-bit DUID is extracted. However, I notice that even though 2 dibits are read, only the most significant bits of each are used (and subsequently compared). Is this intentional?

The reason I ask is because the trunking protocol uses a DUID of 0x7 or 0xC which can't be represented by 2 bits.

sbromberger commented 9 years ago

Ok, on a deeper look we're just creating [0-3][0-3] representations of the dibit. Sorry to have bothered you. Closing this out.