Regression in wrench reftest results

szeged / webrender

A GPU-based renderer for the web

https://doc.servo.org/webrender/

Mozilla Public License 2.0

45 stars 7 forks source link

Regression in wrench reftest results #277

Closed zakorgy closed 5 years ago

zakorgy commented 5 years ago

The text\split-batch.yaml fails with 25 pixel difference, and the image\tile-repeat-prim-or-decompose.yaml crashes, because we run out of descriptors. The fail was introduced in https://github.com/szeged/webrender/commit/1e81eaf8fa8ddbed1f8beda20a18bfc8787c7e80, where we started using the max_image_array_layers limit from gfx-hal. Previously we had a constant 2048 value there. This only affects the Vulkan backend.

zakorgy commented 5 years ago

This was fixed in https://github.com/szeged/webrender/pull/284

zakorgy commented 5 years ago

The reftests\performance\no-clip-mask.yaml became flaky since 067866cca361c0a754006c7898fc497f97cb26c2, the issue is caused most probably by winit 0.19 because before https://github.com/gfx-rs/gfx/commit/62cf11fae402dfa35f24bf1f99ad1a1c1d2743f0 the test works fine.

zakorgy commented 5 years ago

The above issue is fixed after https://github.com/rust-windowing/winit/pull/888 landed in winit

zakorgy commented 5 years ago

This turned to be an issue on my side, switching from nightly to stable rust and adding a minor correction fixed the issue.