szeged / webrender

A GPU-based renderer for the web
https://doc.servo.org/webrender/
Mozilla Public License 2.0
45 stars 7 forks source link

Reftest regression with gfx-backend-metal 0.3.3 #309

Closed zakorgy closed 4 years ago

zakorgy commented 4 years ago

reftests/split/nested-preserve3d-crash.yaml reftest fails with when running all the reftests (otherwise it passes): REFTEST TEST-UNEXPECTED-FAIL | reftests/split/nested-preserve3d-crash.yaml == reftests/split/nested-preserve3d-crash.yaml | image comparison, max difference: 255, number of differing pixels: 19194. The issue was introduced in f488584114728b5bc7745460442e7fc5df9a7f81, which is a gfx-rs update. The previous version of gfx-backend-metal was 0.2.0. The images from the base64 output: Result: cbimage

Reference: cbimage-2

kvark commented 4 years ago

Interesting, thanks for the investigation! Would you be able to provide a Metal GPU capture?

zakorgy commented 4 years ago

11e3f61060c6c83d455e456f2bac4fc1abe4b873 introduced new fails with metal backend:

these are blending related

zakorgy commented 4 years ago

The fails in https://github.com/szeged/webrender/issues/309#issuecomment-542669184 were fixed in #323 and the fails in https://github.com/szeged/webrender/issues/309#issue-491595364 seems to be absent with our latest version (c9a99e4f3b2397cbd3fe59159d572bf5a91ba895).