search

szeged / webrender

A GPU-based renderer for the web
https://doc.servo.org/webrender/
Mozilla Public License 2.0
45 stars 7 forks source link

Window flicking and crash when using Metal backend in Gecko #332

Open f32by opened 5 years ago

f32by commented 5 years ago

Hi, I tried https://github.com/zakorgy/gecko-dev/tree/ff_77_0a1_gfx from @zakorgy but window is flicking.

Firefox crashes when

  1. moving window(randomly, tested multiple times but only crashed once)
  2. closing window (~50%)
  3. browsing https://browserbench.org/MotionMark1.1/ (100%)

crash logs: https://gist.github.com/hellotanuky/548ae8117286437deccd1e1b6b4ca2de

zakorgy commented 5 years ago

@hellotanuky thanks for reporting this, we are already aware of that flickering see https://github.com/szeged/webrender/pull/330. From the log you linked I would suspect that we either run out of the size of the staging buffer, or a memory allocation fails. I will add this to my TODO list, and will look into it next week.

f32by commented 5 years ago

I tried https://github.com/szeged/webrender/pull/330 and this time window is flickering when resizing. Moreover, the entire window only repaints when resizing...

zakorgy commented 5 years ago

@hellotanuky sorry for the late response.

I tried #330 and this time window is flickering when resizing. Moreover, the entire window only repaints when resizing...

With #331 this should be solved, I'll update my gecko-repository in the next days, and will ping you after that.

zakorgy commented 5 years ago

@hellotanuky I've updated https://github.com/zakorgy/gecko-dev/commits/ff_77_0a1_gfx with our latest WR.

f32by commented 5 years ago

Thanks! I'll have a try

zakorgy commented 5 years ago

@hellotanuky I would recommend you to try a WIP branch where some dependencies have performance critical bugs fixed : https://github.com/zakorgy/gecko-dev/tree/ff_77_0a1_gfx-patched , this version runs much faster.