szeged / webrender

A GPU-based renderer for the web
https://doc.servo.org/webrender/
Mozilla Public License 2.0
45 stars 7 forks source link

Check the validation layer #80

Open dati91 opened 6 years ago

dati91 commented 6 years ago

Now that most of the major components are in place, we should pay more attention to the validation layer.

We can collect the issues here and identify the corresponding code, then fix it.

dati91 commented 6 years ago

The following errors are from this revision. I ran the basic and blob examples and picked the common errors for starter.

There are other errors, but we can start with these first.

kvark commented 6 years ago
dati91 commented 6 years ago

More errors:

From basic:

From blob:

From both:

dati91 commented 6 years ago

vkCreateSampler() already addressed in gfx-rs/gfx@e302712

The issue

ERROR:: [ParameterValidation] vkCreateSampler(): The samplerAnisotropy feature was not enabled at device-creation time, so the maxAnisotropy member of the VkSamplerCreateInfo structure must be 1.0 but is 0.000000.

is still exist because the default value here is set to 0.0 instead of 1.0 as the error states.

cc @kvark

kvark commented 6 years ago

argh, sorry

zakorgy commented 6 years ago

Another error:

dati91 commented 6 years ago
dati91 commented 6 years ago

The remaining issues:

We need to fix the barriers #99

The cache clip shaders don't use the aData input attributes.

We are not releasing the resources correctly

dati91 commented 6 years ago
dati91 commented 6 years ago

It seems like I missed something in the latest rebase. It most probably related to the new DashAndDot Vertex array kind.

dati91 commented 6 years ago
zakorgy commented 5 years ago

After updating the VulkanSDK we have new validation layer error(s), which we should take care:

Descriptor set related:

These are happening after window resize:

These are related for examples:

image_resize example:

document example:


And there is a D3D12 error:

zakorgy commented 5 years ago

We encountered the following issue with an Nvidia card:

zakorgy commented 5 years ago

These are Gecko related: