search

szeiger / ornate

A Markdown-based site generator
http://szeiger.github.io/ornate-doc/
Other
80 stars 12 forks source link

update to Scala 2.12 and sbt 1.1 #15

Closed bpholt closed 5 years ago

bpholt commented 6 years ago

This should cross-publish for Scala 2.11 and 2.12, but only with sbt 1. Hopefully losing sbt 0.13 support is acceptable.

This would fix #14 and supersedes #12.

bpholt commented 6 years ago

I'm not sure why the build is failing on TravisCI; running admin/build.sh works locally for me.

The command "openssl aes-256-cbc -K $encrypted_950849751342_key -iv $encrypted_950849751342_iv -in secrets.tar.enc -out secrets.tar -d" failed and exited with 1 during .

I suspect @szeiger will need to investigate why that's failing.

easel commented 6 years ago

I was able to get this to build locally with 'plugin/publishLocal', it would be great to get something sbt 1.0 compatible published. I made an attempt at getting a cross-build to work but so far no luck.

caente commented 6 years ago

I made an attempt at getting a cross-build

why not just have a new version of ornate that only works with sbt 1?

bpholt commented 6 years ago

why not just have a new version of ornate that only works with sbt 1?

@caente unless I'm misunderstanding you, that's what this PR does.

caente commented 6 years ago

perhaps I misunderstood you, I thought the issue holding this PR back was the failure to cross compile, I suggested to not support 2.11 in the new version

easel commented 6 years ago

I think you're both correct -- this PR is sbt 1.0 only and does appear to work. It may or may not actually be held back by that, the repo owner hasn't weighed in on it.

szeiger commented 5 years ago

Hm, maybe just a bug in the script? PR builds from 3rd parties don't get the key for decrypting secrets. I'm looking into it.

szeiger commented 5 years ago

I thought I had done this before and it's really just standard Travis file encryption. I expected the build to continue without decrypting the secrets when the key is not set. I'll hack around it and rebase the PR.

szeiger commented 5 years ago

OK, that worked, but there's another build error. It can't find the sbt plugin for testing.

szeiger commented 5 years ago

Ah, it fails because it now tries to resolve the 2.12 version of Ornate for the scripted tests but they haven't been published yet at that point. The easiest way to fix this is to drop 2.11 support.

szeiger commented 5 years ago

Looks good. Thanks for opening this @bpholt