search

szellmann / visionaray

A C++-based, cross platform ray tracing library
https://vis.uni-koeln.de/visionaray.html
MIT License
429 stars 37 forks source link

CMakeLists.txt: Propagating include directory. #35

Closed ghost closed 4 years ago

ghost commented 4 years ago

This just makes it easier when using the library as a subdirectory (via add_subdirectory()) so that you don't have to install it into a temporary directory.

szellmann commented 4 years ago

Awesome thank you, I also use it as a submodule in several projects and that is always a bit annoying to get right with the headers (esp. the config header).

Would you know if this is still compatible with cmake 2.8.9? Google search seems to indicate that target_include_directories came with 2.8.12. I'm good with that but would like to update the cmake_minimum_required command and readme accordingly.

ghost commented 4 years ago

Ah, yeah I should've checked that. I can make a follow up PR for that