szellmann / visionaray

A C++-based, cross platform ray tracing library
https://vis.uni-koeln.de/visionaray.html
MIT License
431 stars 37 forks source link

CMakeLists.txt: Bump minimum required to 2.8.11 #36

Closed ghost closed 4 years ago

ghost commented 4 years ago

According to this, it's been available since 2.8.11, released about seven years ago.

szellmann commented 4 years ago

Great thank you! I would btw. good with much newer cmake (if that's necessary). Currently the oldest OS where I'd like to support building against system packages is Ubuntu 16.04 and that has cmake 3+.

ghost commented 4 years ago

Okay, good to know. I think there are some useful tricks for exporting library targets that I'd like to get in at some point, it's just hard to find the motivation since it already works out of the box.

szellmann commented 4 years ago

Yeah same here, hard to find motivation if things work.

The build system was actually adopted from another project and written around 2012. So lots of old-style cmake that could (and probably should) be done differently nowadays :-)