search

szellmann / visionaray

A C++-based, cross platform ray tracing library
https://vis.uni-koeln.de/visionaray.html
MIT License
431 stars 37 forks source link

Tests #8

Closed tu500 closed 8 years ago

tu500 commented 8 years ago

Refactored unittests, added compile failure tests, ctest integration and travis configuration.

szellmann commented 8 years ago

This breaks travis builds on Ubuntu 12.04 - target_compile_definitions was introduced with CMake 2.8.11. Could you find a workaround? CI tests on osx work just fine btw.

I'd rather not have an extra option like VSNRAY_ENABLE_COMPILE_FAILURE_TESTS. Could you come up with an alternative (e.g. checking the cmake version and only conditionally traversing down the directory structure and printing some error message or so)?

Lets hope for travis having a stable Ubuntu 14.04 implementation soon.

szellmann commented 8 years ago

Works, thanks. Merged!