search

szepeviktor / composer-envato

Composer plugin for Envato 💚 Install WordPress themes and plugins from ThemeForest‎‎ and CodeCanyon
https://packagist.org/packages/szepeviktor/composer-envato
MIT License
32 stars 3 forks source link

Add return types to match newer Composer versions #10

Closed DannyTaki closed 1 year ago

DannyTaki commented 1 year ago

I just updated the return type of the method getDistType() to a string and one other method which PHPStan flagged. Also checked if some variable were null in EnvatoApi.php. PHPstan is showing no errors up to level 6

szepeviktor commented 1 year ago

Thank you very much! This looks very nice.

Could you update Composer version constraint to where : string return type was introduced?

szepeviktor commented 1 year ago

Done.

Have you noticed that your commits are made with a non-GitHub email address? maybe https://github.com/settings/emails

DannyTaki commented 1 year ago

Haha that was my first real pull request besides documentation edits :). That was fun. Thanks! I have email configured as my gmail should I be using another email?

szepeviktor commented 1 year ago

These two commits are made with your "alliance" email address.

DannyTaki commented 1 year ago

Oh that's prollly because I pushed the changes from my work computer. That's fine not a big deal