szepeviktor / composer-envato

Composer plugin for Envato 💚 Install WordPress themes and plugins from ThemeForest‎‎ and CodeCanyon
https://packagist.org/packages/szepeviktor/composer-envato
MIT License
32 stars 3 forks source link

Add support for loading personal token from environment variable or `.env` file #14

Closed mcaskill closed 1 year ago

mcaskill commented 1 year ago

Changed:

Alternatively, instead of requiring vlucas/phpdotenv, we could add conflict and suggest entries to the composer.json and check if the class exists before attempting to load Dotenv.

szepeviktor commented 1 year ago

This is a very nice feature. Let the major version be raised!

Thank you.

mcaskill commented 1 year ago

[…] instead of requiring vlucas/phpdotenv, we could add conflict and suggest entries to the composer.json and check if the class exists before attempting to load Dotenv.

What do you think about this proposal?

For those that define their environment variables outside of a .env file, skips the extraneous extra dependency.

szepeviktor commented 1 year ago

skips the extraneous extra dependency

We should not be that top notch!

szepeviktor commented 1 year ago

Thank you Chauncey!