search

szepeviktor / courier

Courier Mail Server, also see https://github.com/szepeviktor/courier-libs
http://www.courier-mta.org
0 stars 0 forks source link

Reverse order of imapd and imapd-ssl config files #10

Open szepeviktor opened 7 years ago

szepeviktor commented 7 years ago

@mwanner The original /usr/lib/courier/imapd script has the sourcing order:

. /etc/courier/imapd-ssl
. /etc/courier/imapd

but SysVinit scripts:

imapd
imapd-ssl

Please advise.

szepeviktor commented 7 years ago

Courier's SysVinit script: https://github.com/svarshavchik/courier/blob/master/courier/courier.sysvinit.in#L170-L177

szepeviktor commented 7 years ago

Oh no! Excuse me.

In /usr/bin/env command the order is the same.

mwanner commented 7 years ago

On 08/18/2017 12:47 PM, Viktor Szépe wrote:

Please advise.

Last time I checked, it's one way for ssl and the other for non-ssl. That's a bit weird, but allows for general configuration of both services in any of the two files, also allowing to override the configuration for a specific variant.

I.e. I'd expect the imports for the ssl variant to be: imap, then imap-ssl. And for the non-ssl variant: imap-ssl, then imap.

While I see the benefits of doing it that way, I think it's more confusing than helpful. However, it's upstream's decision and I tried to replicate the functionality for init.d and systemd in Debian.

Kind Regards

Markus Wanner

szepeviktor commented 7 years ago

Sam also has the same opinion

No, this is intentional. They share the same settings, and this allows, for example, for imapd-ssl's settings to override imapd's, for the server on the SSL port, or for imapd's settings to override imapd-ssl's, for the server on port 143.

szepeviktor commented 7 years ago

@mwanner I think Debian's init script should follow the same order.

Should I open a Debian bug?