search

szepeviktor / phpstan-wordpress

WordPress extensions for PHPStan ⛏️
https://packagist.org/packages/szepeviktor/phpstan-wordpress
MIT License
262 stars 26 forks source link

`current_time` return type changed #189

Closed szepeviktor closed 1 year ago

szepeviktor commented 1 year ago

https://github.com/szepeviktor/phpstan-wordpress/blob/5d1c8ce8a8e718465692d79a7912dfefed6d9193/tests/data/current_time.php#L27

Has core changed its type?? No: int|string Integer if $type is 'timestamp' or 'U', string otherwise.

https://app.travis-ci.com/github/szepeviktor/phpstan-wordpress/jobs/604190969#L481 👀

Anyone with a keyboard? :)

szepeviktor commented 1 year ago

We have done that! https://github.com/php-stubs/wordpress-stubs/blob/121cc84f3cdad465354006f4fac91eef627483de/functionMap.php#L82

IanDelMar commented 1 year ago

We should drop tests for unsupported types. PHPStan should warn about the parameter not being a string.