szepeviktor / w3-total-cache-fixed

A community driven build of W3 Total Cache. The aim is to continuously incorporate fixes, improvements, and enhancements over the official WordPress release of W3 Total Cache.
https://github.com/szepeviktor/w3-total-cache-fixed/releases
MIT License
237 stars 47 forks source link

Official W3TC has been updated to 0.9.6 #546

Closed nigrosimone closed 6 years ago

nigrosimone commented 6 years ago

The Official W3TC has been updated to 0.9.6 with so many W3TC-FIX fixes, improvements and enhancements.

Fixed anonymous usage tracking, default to disabled Fixed incorrect minify cache data written if target directory missing Fixed empty minify cache file written when file locking enabled Fixed missing commas in CSS (@nigrosimone) Fixed typo in object cache engine (@Furniel) Fixed incorrect reuse of redis connections when persistent connections option enabled Fixed reliability of Google Drive (via @jikamens) Fixed handling of UTF-8 encoded files by writing them in binary (via @jikamens) Improved Full Site Delivery configuration user flow on the General and CDN settings screens Improved content type matching and cache hits as a result Improved minify file locking logic Improved visual langage of the compatibility test (@Furniel) Improved configuration file management Improved MaxCDN set up wizard Improved page cache’s accepted query string handling to handle optional values and add support for disk enhanced mode (via @amiga-500, @nigrosimone) Improved handling of timeouts to origin push CDN proviers Added HTTP/2 push headers for disk enhanced page caching (via @nigrosimone) Added X-Forwarded-Proto header for use cases like HTTPS recognition behind proxies or load balancers Added multiple CDN support i.e. static file objects and pages, posts, feeds, API responses etc to use different respective CDN providers Added page caching by cookie name or value (sponsored by SQweb) Added toggle for CORS header to improve inter-operatbility with various CDN providers Added support for CDN hosted media to media library (inspired by @amiga-500) Added object caching of AJAX calls (via @andyexeter) Enterprise features are now available to Pro subscribers! Including reading from multiple databases concurrently and purging caches across multiple hosts via a Message Bus

see https://wordpress.org/plugins/w3-total-cache/#developers

Anyone can help me to check if there are all w3tc-fix changes?

I'm checking the changes and the official w3tc seems to have all community fixes.

from latest PRs: https://github.com/szepeviktor/w3-total-cache-fixed/pull/537 OK https://github.com/szepeviktor/w3-total-cache-fixed/pull/527 OK https://github.com/szepeviktor/w3-total-cache-fixed/pull/522 OK https://github.com/szepeviktor/w3-total-cache-fixed/pull/523 PARTIAL https://github.com/szepeviktor/w3-total-cache-fixed/pull/524 OK https://github.com/szepeviktor/w3-total-cache-fixed/pull/525 NO https://github.com/szepeviktor/w3-total-cache-fixed/pull/520 OK

for knowledge, all contributors @szepeviktor, @charlesLF, @archon810, @andyexeter, @marian-kadanka, @raphaelquati, @niklasfink, @sbutler, @Crevil, @viawest-davidsix, @mrosenberg, @jikamens, @amiga-500, @Furniel

szepeviktor commented 6 years ago

Nice from Frederick that he follows our repo.

Personally I run all websites on cloud servers providing Redis cache. So for caching WordPress post content, translations and nav menu output I've developed Tiny cache and Tiny CDN. You can find it here https://github.com/szepeviktor/tiny-cache

andyexeter commented 6 years ago

The only thing I’d mention about my PR #537 is that the description isn’t really accurate.

The PR fixes object caching of arbitrary data within AJAX calls, rather than adding object caching of AJAX calls :)

szepeviktor commented 6 years ago

See https://github.com/szepeviktor/w3-total-cache-fixed/pull/537 again :)

andyexeter commented 6 years ago

I mean in the release notes, it says “Added object caching of AJAX calls” which isn’t quite right :)

szepeviktor commented 6 years ago

Fixed

charlesLF commented 6 years ago

Cool

We'll have to spend a bit of time identifying and reconciling the differences in both codes.

EDIT: doesn't look too bad. I can take care of this sometime in the next couple of days.

Here is a checklist for you

szepeviktor commented 6 years ago

@charlesLF I've added a list into your comment.

lvl99 commented 6 years ago

Just a question: is the official W3 Total Cache plugin catching up to this version of the plugin, or does this version of the plugin need to incorporate aspects of the official plugin?

I keep getting a reminder from Wordfence to update W3TC, but I'm waiting for a v0.9.6 release on this repo, rather than use the official...

charlesLF commented 6 years ago

Too many differences, too little time. I will keep using the v0.9.5.x branch on this repo since it's working just fine in all my setups.

Anyone else up to reconciling the differences?

cre8gr commented 6 years ago

Well,

The plugin has a serious issue that the developer has yet to fix it. Too much error 500.

See here for details: https://wordpress.org/support/topic/fatal-error-2749/

Most of the people I know haven't updated, or reverted to the previous version because of it.

nigrosimone commented 6 years ago

@cre8gr this is my fix https://wordpress.org/support/topic/fatal-error-2749/#post-9779929

nigrosimone commented 6 years ago

@charlesLF

Too many differences, too little time.

true... i have also tried ... it's a mission inpossible for me.

Furniel commented 6 years ago

Descided to help and reviewed all commits and picked missing or in some cases partially missing to 0.9.6.x_wip branch. All other commits were already merged to 0.9.6 or in some cases bugs were fixed in other way. And i skipped commits that were changing only readme files(for new release they should be rewritten).

PS: I don't use wordpress in my projects at this moment, so i can't test new version and check how it works.

nigrosimone commented 6 years ago

hi @Furniel thanks again! great work!

nigrosimone commented 6 years ago

@szepeviktor, @Furniel has merged Fixed version with last official version into 0.9.6.x_wip branch. In the past you have made the switch, you can made the same magic?

szepeviktor commented 6 years ago

@Furniel Thank you. This is the default branch now.

szepeviktor commented 6 years ago

@nigrosimone Could you please double-check that 56f1c452fcdaf7631d893fd5dcbf44d27a7fc085 is really bit-by-bit equal to WP.org zip?

nigrosimone commented 6 years ago

@szepeviktor, @Furniel the https://github.com/szepeviktor/w3-total-cache-fixed/blob/v0.9.6.x_wip/README.md is out of sync with https://github.com/szepeviktor/w3-total-cache-fixed/wiki/Changelog.

It seem we have lose the last 14 PR. in the readme.md the last update is "Colored self test window", in the wiki "Fix object caching of arbitrary data within AJAX calls". What happened?

szepeviktor commented 6 years ago

The readme was updated on dec. 24. https://github.com/szepeviktor/w3-total-cache-fixed/commits/v0.9.6.x_wip/README.md

Furniel commented 6 years ago

@nigrosimone As I mentioned earlier, readme files should be updated(rewritten) for new branch. For example "Fix object caching of arbitrary data within AJAX calls" commit was merged by w3tc devs and original 0.9.6 version contains this commit. As result i skipped original commit and it was not merged to 0.9.6_wip branch and README.md is not updated and does not contain :beetle: Bug Fix | [Fix object caching within AJAX requests](https://github.com/szepeviktor/w3-total-cache-fixed/pull/537) | line.

As mentioned in readme.md it contains changes Since the last official release of W3 Total Cache (v0.9.5.2) and i think that for 0.9.6 branch it should be rewritten and contain changes since 0.9.6 release, but on wiki page should be mentioned all changes by w3-total-cache-fixed contributors(that were or not merged by w3tc devs).

szepeviktor commented 6 years ago

This reasoning seems reasonable :)

szepeviktor commented 6 years ago

@nigrosimone Hello! Are you proceeding with the new release?

nigrosimone commented 6 years ago

I'm a bit busy now, but i have 2 bug fix ready over the last official release.

szepeviktor commented 6 years ago

@nigrosimone Thank you for the release.

nigrosimone commented 6 years ago

@szepeviktor i have found a bit of time for made the new release :D