search

szimek / sharedrop

Easy P2P file transfer powered by WebRTC - inspired by Apple AirDrop
https://www.sharedrop.io
MIT License
9.35k stars 682 forks source link

Allow custom names for users (machines) #142

Open brunetton opened 1 year ago

brunetton commented 1 year ago

Hi, I plan to use Sharedrop for realtime team collaboration; but when more than 3 or 4 computers on the same room, it starts to be hard to remember "who is who", ie who is "Romantic Piglet" again ? Is this Paul ? Or Linus ?

It would be great to be able to define custom names

szimek commented 1 year ago

Hey! It's been requested a few times already. I have some concerns that in specific use cases people could impersonate others. However, I understand that in other use cases, like yours, it would be useful.

The logic to implement it is relatively simple, the biggest issue is actually UI. When I have some free time, I'll see if it's possible to reuse the existing dialog component for it - this way the UI could be the same for desktop and mobile.

Also, pull requests are very welcome :)

brunetton commented 1 year ago

Hey! It's been requested a few times already. I have some concerns that in specific use cases people could impersonate others. However, I understand that in other use cases, like yours, it would be useful.

The logic to implement it is relatively simple, the biggest issue is actually UI. When I have some free time, I'll see if it's possible to reuse the existing dialog component for it - this way the UI could be the same for desktop and mobile.

Also, pull requests are very welcome :)

Hi, thanks for your answer. This goes to my "PR ideas" inbox; but I'm really not confortable with Node environment (at all) unfortunately.

So I suppose I'll wait ;)