szimek / sharedrop

Easy P2P file transfer powered by WebRTC - inspired by Apple AirDrop
https://www.sharedrop.io
MIT License
9.35k stars 682 forks source link

Sending Folder is empty when unzip #145

Open TheArctesian opened 1 year ago

TheArctesian commented 1 year ago

Sending a folder of md files with nested folders.

I am on Arch my friend was on IOS, when the file was sent through and unzip, MacOS threw an error saying the file was empty.

I will do some more testing and maybe clone it and play around but just thought would let you know.

riton commented 1 year ago

Same problem using a Linux desktop (with Brave browser) and Android (with Brave browser). The test was performed with only two .txt files at the root of the directory I was sending:

❯ tree .
.
├── date-2.txt
└── date.txt

0 directories, 2 files

zip file is transferred but appears empty on my phone.

szimek commented 1 year ago

@riton Hi! Just to confirm - did you select both files, or the folder that they are in?

riton commented 1 year ago

@riton Hi! Just to confirm - did you select both files, or the folder that they are in?

I've dragged and dropped the folder from Thunar (my file manager in XUbuntu) to firefox

szimek commented 1 year ago

Thanks @riton. Yeah, at the moment, it does not support uploading folders. I'd have to check if it's possible/easy to distinguish between a file and a folder, and if it's possible to read files from a folder. Either I could add a support for it, or at least show an error, suggesting to drop multiple files instead.