szimek / sharedrop

Easy P2P file transfer powered by WebRTC - inspired by Apple AirDrop
https://www.sharedrop.io
MIT License
9.99k stars 729 forks source link

Blocking Sentry seems to break the app #175

Open dgw opened 1 month ago

dgw commented 1 month ago

I loaded the main ShareDrop instance on Firefox (Steam Deck, which uses an Arch-ish Linux) with uBlock Origin enabled, and found myself unable to accept a transfer request from my Android phone.

Digging into the browser console on the Deck revealed failing requests to Sentry every time I tried to click the button that would accept the transfer. Disabling uBO for sharedrop.io let me complete the process.

Honestly, inability to connect to a logging service shouldn't be a show-stopper. I believe the app should handle the error and continue. (I also think it's hilarious and sad that ShareDrop would be immediately better than 95% of mobile-ordering apps I've had to install for various chains if it gracefully handled being blocked from sending out metrics.)

I apologize if I'm missing something obvious, or if I've followed a red herring in the JS error log. My interest is only in helping make ShareDrop more reliable even for privacy-conscious users.

szimek commented 1 month ago

Thanks for reporting it. I'll try to look into it this week.