search

szimek / sharedrop

Easy P2P file transfer powered by WebRTC - inspired by Apple AirDrop
https://www.sharedrop.io
MIT License
9.99k stars 729 forks source link

QR code Sharing URL #51

Closed avinayak closed 5 years ago

avinayak commented 7 years ago

It's easier to share if there is a qr code generator and reader on mobile devices.

jrruethe commented 7 years ago

I agree completely, this would be a great enhancement

szimek commented 7 years ago

In case of local sharing the url doesn't change - it's always sharedrop.io. In case of sharing between networks, what's the advantage of using QR code over copying it from a text input? You still need to send it using an email or some app to another person.

jrruethe commented 7 years ago

An example would be if I am in front of a computer with ethernet and my phone is on 4G. It would be much easier to scan the screen than type in a number. Just because the devices are physically co-located doesn't mean the devices are on the same LAN.

szimek commented 7 years ago

@jrruethe Looks like a valid (though probably not very common) case ;)

If anyone wants to create a PR, they are very welcome. There's an add-on for this: https://github.com/AlexeiDrake/ember-qrcode, so it shouldn't be hard.

glowcone commented 6 years ago

Hey, I'd like to take a crack at this. Haven't used ember before, but will try and see

szimek commented 6 years ago

@recurza Good luck! The code is rather old and most likely is not according to todays Ember standards :/

I started updating the whole thing to ES6 (https://github.com/cowbell/sharedrop/tree/es6), but can't find time to finish it.

glowcone commented 6 years ago

Oh! I'd be interested in helping with the ES6 transition as well. Will go take a look

DJCrashdummy commented 5 years ago

i guess this can be closed, or am i wrong?

szimek commented 5 years ago

Yeah, thanks!