search

szimek / sharedrop

Easy P2P file transfer powered by WebRTC - inspired by Apple AirDrop
https://www.sharedrop.io
MIT License
9.99k stars 729 forks source link

Upgrade to Ember 3 + packages #66

Closed bl4ckm0r3 closed 5 years ago

bl4ckm0r3 commented 5 years ago

Just upgraded Ember to 3.4.2 (latest) and changed firebase logic to use the most up to date library. I didn't refactor much to avoid making this a huge change. There is definitely a refactor to be done but on a future PR.

szimek commented 5 years ago

Thank you so much! I'll check it out later this week and deploy it to staging (http://sharedrop-staging.herokuapp.com/) first to test it a bit.

BTW. I completely agree regarding the need for refactoring. I actually wanted to rewrite it completely using a different framework, e.g. preact or vue, just to try out stuff I haven't worked with yet. Also, I also wanted to switch from using PeerJS to https://github.com/webtorrent/webtorrent or https://github.com/feross/simple-peer and add some tests, but I simply can't find enough free time to start working on it again.

bl4ckm0r3 commented 5 years ago

Cool! i have done some local test but i am sure you'll have more chances to test it! Webtorrent is great!if you want I can help, but I'd like to do a refactor pr first so it would make things easier.

szimek commented 5 years ago

Thank you so much for taking time to work on this! I did some refactoring (removed fetching private IPs, added eslint, prettier etc) and also updated Ember to the latest version (3.7.x).

bl4ckm0r3 commented 5 years ago

thank you for updating your app!! i keep loving it!