search

szimek / sharedrop

Easy P2P file transfer powered by WebRTC - inspired by Apple AirDrop
https://www.sharedrop.io
MIT License
9.94k stars 725 forks source link

Replace v1 with v4 UUID #78

Closed ctavan closed 4 years ago

ctavan commented 5 years ago

I'm a co-author of the uuid npm module which is being used in some places within the code base of sharedrop.

I'm currently trying to understand real-world use cases of time-based UUIDs ("v1 UUIDs").

I found one occurrence where v1 UUIDs were being used instead of v4 UUIDs and I was wondering if this case really requires the semantically much more complex v1 UUIDs or whether we could live equally well with purely random v4 UUIDs?

I also used the opportunity to replace the deprecated node-uuid dependency with uuid, the official successor of node-uuid.

I'd be really curious to understand the motivation for choosing v1 over v4 UUIDs in the first place, so any feedback on this would be highly appreciated!

matbrgz commented 4 years ago

LGFM

szimek commented 4 years ago

Thanks! I've updated it along with other dependencies.