szimek / signature_pad

HTML5 canvas based smooth signature drawing
http://szimek.github.io/signature_pad/
MIT License
10.92k stars 2.11k forks source link

Typescript error with `signature_pad` as project dependency. #699

Closed paulferrett closed 1 year ago

paulferrett commented 1 year ago

Do you want to request a feature or report a bug? Report a Typescript compilation error.

What is the current behavior?

When compiling our project which has signature_pad as a dependency, the following typescript error


info  - Checking validity of types...
--
125 | Failed to compile.
126 |  
127 | ./node_modules/signature_pad/src/signature_pad.ts:65:11
128 | Type error: Property '_drawningStroke' has no initializer and is not definitely assigned in the constructor.
129 |  
130 | 63 \|   /* tslint:disable: variable-name */
131 | 64 \|   private _ctx: CanvasRenderingContext2D;
132 | > 65 \|   private _drawningStroke: boolean;
133 | \|           ^
134 | 66 \|   private _isEmpty: boolean;
135 | 67 \|   private _lastPoints: Point[]; // Stores up to 4 most recent points; used to generate a new curve
136 | 68 \|   private _data: PointGroup[]; // Stores all points in groups (one group per line or dot)

Which versions of SignaturePad, and which browser / device are affected by this issue? Did this work in previous versions of SignaturePad? 4.1.4

github-actions[bot] commented 1 year ago

:tada: This issue has been resolved in version 4.1.5 :tada:

The release is available on:

Your semantic-release bot :package::rocket: