search

szimszon / tb-filelink-seafile

Adds the possibility to use a SeaFile store for Filelink
23 stars 10 forks source link

Non ascii characters in password support #2

Open t0mab opened 9 years ago

t0mab commented 9 years ago

This plugin is great but authentification is failling when non ascii characters are used in password. Could you fix this ?

szimszon commented 9 years ago

Could you try that please: https://seafile.oregpreshaz.eu/f/551dfab88d/

t0mab commented 9 years ago

Hey thanks for the fast reply I am trying to debug and fix the problem in fact the problem is not with non ascii nor special ascii characters the problem occurs when you got "&" in your password as it is interpreted as a delimiter for the uri when you use the send method to authenticate. I am trying to use encodeURIComponent without success for now as well I translated the locales for french will send a pull request later. Hope we could fix this tiny problem !

t0mab commented 9 years ago

I shoud say that the 0.10 release does not fix my problem for now !

szimszon commented 9 years ago

As a matter of fact I'm not a big JS coder. So I thank for any help.

In 0.10 I was changed the 998 line in nsSeaFile.js to use encodeURIComponent too... :(

t0mab commented 9 years ago

I tried as well (line 919) return encodeURIComponent(password.value) hope to find something soon !